Skip to content

London | 26-ITP-Sep | Abakar Souleyman | Sprint 1 | Form controls - #1479

Open
abmhts wants to merge 3 commits into
CodeYourFuture:mainfrom
abmhts:feature/form-controls
Open

London | 26-ITP-Sep | Abakar Souleyman | Sprint 1 | Form controls#1479
abmhts wants to merge 3 commits into
CodeYourFuture:mainfrom
abmhts:feature/form-controls

Conversation

@abmhts

@abmhts abmhts commented Sep 8, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1004

Changelist

  • Added required name and email fields with validation.
  • Added 3 colour options using a dropdown.
  • Added 6 T-shirt sizes: XS, S, M, L, XL, XXL.
  • Made all fields required.
  • Used appropriate , , and elements. No form action added, as instructed. Questions Is it mandatory to use CSS as well to complete this task?

@abmhts
Wrote the requirements as comments and added the HTML structure for t…
627518f 
…he Name and Email sections.

Added customer information form fields with validation requirements.
@abmhts
Added T-shirt colour and size options, form validation, and submit bu…
b82bdb5 
…tton
@netlify

netlify Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 5f1b867
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aa5548fd849ba00084fbce5
😎 Deploy Preview https://deploy-preview-1479--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@abmhts abmhts added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
Luro91
Luro91 reviewed Sep 10, 2026
View reviewed changes
Comment thread Form-Controls/index.html

@Luro91 Luro91 Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see an accessibility score of 88 in Lighthouse. How can you get it to 100?

@abmhts abmhts Sep 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lighthouse Score-Form Controls

I’m seeing an accessibility score of 100 on my end, but I might be checking it in the wrong place. Could you point me to where you’re seeing 88? 🙂

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 10, 2026
@abmhts

abmhts commented Sep 12, 2026

Copy link
Copy Markdown
Author
image

I corrected the misspelled element. I also realised I was looking in the wrong place for the accessibility score. 🙂

@Luro91

Luro91 commented Sep 13, 2026

Copy link
Copy Markdown

@abmhts te code works correctly now, is easy to read and meets the accessibility criteria. Well Done.

A note on the review process. Please ensure to always assign the correct labels back when you are done with our changes:

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    - In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    - You may find the suggestions in this PR Guide useful.
    - Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label
    - Without this label, the reviewer would not know if your changes is ready to be reviewed.

@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 13, 2026
@abmhts

abmhts commented Sep 13, 2026

Copy link
Copy Markdown
Author

Well noted, thanks for the feedback!
I’ll make sure to reply to the reviewer’s feedback and change the label from “Reviewed” to “Needs review” whenever I’ve made the requested changes.

Thanks for explaining the review process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Luro91 Luro91 Luro91 left review comments
Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abmhts @Luro91